[Enhancement] Do checkpoint on follower node to relieve memory pressure on leader #52103
+829
−233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gengjun-git <[email protected]>
Signed-off-by: gengjun-git <[email protected]>
[FE Incremental Coverage Report]❌ fail : 40 / 86 (46.51%) file detail
|
Signed-off-by: gengjun-git <[email protected]>
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
kevincai
reviewed
Oct 18, 2024
| @@ -582,6 +582,9 @@ public class Config extends ConfigBase { | |||
| @ConfField | |||
| public static long bdbje_reserved_disk_size = 512L * 1024 * 1024; | |||
|
|
|||
| @ConfField | |||
| public static long checkpoint_timeout_s = 24 * 3600; | |||
There was a problem hiding this comment.
Suggested change
| public static long checkpoint_timeout_s = 24 * 3600; | |
| public static long checkpoint_timeout_seconds = 24 * 3600; |
| @@ -1847,6 +1847,28 @@ struct TGetKeysResponse { | |||
| 1: optional list<binary> key_metas; | |||
| } | |||
|
|
|||
| struct TDoCheckpointRequest { | |||
There was a problem hiding this comment.
name it as TStartCheckpointRequest?
| @@ -179,12 +176,6 @@ protected void runAfterCatalogReady() { | |||
| } | |||
| } // end for all results | |||
|
|
|||
| // we also add a 'mocked' master Frontend heartbeat response to synchronize master info to other Frontends. | |||
| @@ -178,56 +187,6 @@ public Classes getClasses() { | |||
| return classes; | |||
| } | |||
|
|
|||
| static final class Fields { | |||
There was a problem hiding this comment.
looks like a non-related code clean-up, can submit a separate PR to remove these lines through a fast-track code review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
The current Leader has a Checkpoint daemon thread that continuously checks for new journal dbs. If a new journal db is detected, the following steps are performed:
The main differences of the optimized process are as follows:
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: