Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support backup restore for logical view #52077

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Enhancement] Support backup restore for logical view #52077

wants to merge 1 commit into from
+419 −26

Conversation

srlch
Copy link
Contributor

@srlch srlch commented Oct 18, 2024 •
edited
Loading

Support backup restore for logical view

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@wanpengfei-git wanpengfei-git requested a review from a team October 18, 2024 05:59
@mergify mergify bot assigned srlch Oct 18, 2024
@srlch srlch force-pushed the support_backup_restore_view branch from 356f607 to e92e4c1 Compare October 18, 2024 10:57
@srlch srlch force-pushed the support_backup_restore_view branch from e92e4c1 to 289cbeb Compare October 18, 2024 14:54
@srlch srlch changed the title [WIP] support backup restore for logical view [Enhancement] Support backup restore for logical view Oct 18, 2024
@srlch srlch marked this pull request as ready for review October 18, 2024 14:54
@srlch srlch requested review from a team as code owners October 18, 2024 14:54
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 27 / 95 (28.42%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/backup/RestoreJob.java 1 61 01.64% [508, 509, 510, 511, 515, 516, 517, 548, 549, 550, 552, 553, 554, 555, 577, 579, 718, 719, 797, 798, 799, 800, 801, 802, 872, 873, 874, 875, 876, 877, 883, 884, 885, 886, 887, 890, 891, 894, 895, 897, 898, 899, 900, 901, 903, 904, 906, 909, 912, 913, 914, 915, 917, 918, 919, 920, 922, 923, 1216, 1588]
🔵 com/starrocks/backup/BackupHandler.java 4 10 40.00% [328, 329, 333, 334, 335, 336]
🔵 com/starrocks/backup/BackupJob.java 12 14 85.71% [401, 402]
🔵 com/starrocks/backup/Status.java 1 1 100.00% []
🔵 com/starrocks/backup/BackupJobInfo.java 8 8 100.00% []
🔵 com/starrocks/catalog/View.java 1 1 100.00% []

@github-actions github-actions bot added the 3.3 label Oct 18, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@srlch srlch

Labels
3.3 behavior_changed META-REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srlch @wanpengfei-git