[BugFix] Fix online optimize conflict with expression partition #52074
+300
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meegoo
force-pushed
the
fix_online_optimize
branch
from
5b78604
to
bfe90b7
Compare
gengjun-git
previously approved these changes
Oct 18, 2024
wyb
reviewed
Oct 18, 2024
| @@ -196,7 +196,8 @@ public enum OlapTableState { | |||
| * The query plan which is generate during this state is invalid because the meta | |||
| * during the creation of the logical plan and the physical plan might be inconsistent. | |||
| */ | |||
| UPDATING_META | |||
| UPDATING_META, | |||
| OPTIMIZE | |||
There was a problem hiding this comment.
are there any compatibility issues with upgrade or rollback when optimize job is running?
There was a problem hiding this comment.
it should be compatibility with upgrade or downgrade since replay will update table state.
Signed-off-by: meegoo <[email protected]>
meegoo
force-pushed
the
fix_online_optimize
branch
from
bfe90b7
to
b4c3dd1
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 19 / 21 (90.48%) file detail
|
[BE Incremental Coverage Report]✅ pass : 14 / 16 (87.50%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes https://github.com/StarRocks/StarRocksTest/issues/8485
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: