Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix running fragment count during exec env exit #52048

Merged
merged 1 commit into from
Oct 18, 2024
Merged

[BugFix] fix running fragment count during exec env exit #52048

merged 1 commit into from
Oct 18, 2024

Conversation

kevincai
Copy link
Contributor

@kevincai kevincai commented Oct 17, 2024 •
edited
Loading

  • need to support both pipeline engine and non-pipeline engine env
  • reject exec_batch_plan_fragments interface as well during shutdown

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@kevincai kevincai requested a review from a team as a code owner October 17, 2024 09:32
@kevincai
[BugFix] fix running fragment count during exec env exit
2fae253 
* need to support both pipeline engine and non-pipeline engine env
* reject exec_batch_plan_fragments interface as well during shutdown

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
@kevincai kevincai force-pushed the grace-exit-count-fragment-pipeline branch from 9c8a6b8 to 2fae253 Compare October 18, 2024 02:12
@kevincai kevincai requested a review from a team as a code owner October 18, 2024 02:12
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

❌ fail : 2 / 19 (10.53%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/service/internal_service.cpp 0 8 00.00% [96, 97, 306, 338, 339, 340, 341, 1250]
🔵 be/src/runtime/exec_env.cpp 2 11 18.18% [722, 723, 725, 726, 727, 728, 729, 733, 736]

@wyb wyb enabled auto-merge (squash) October 18, 2024 06:31
@wyb wyb merged commit e259267 into StarRocks:main Oct 18, 2024
46 of 47 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Oct 18, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 18, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 18, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 18, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 18, 2024
@kevincai @mergify
[BugFix] Fix running fragment count during exec env exit (#52048)
cfcc0f7 
Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit e259267)

# Conflicts:
#	be/src/testutil/init_test_env.h
mergify bot pushed a commit that referenced this pull request Oct 18, 2024
@kevincai @mergify
[BugFix] Fix running fragment count during exec env exit (#52048)
57ec392 
Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit e259267)

# Conflicts:
#	be/src/testutil/init_test_env.h
This was referenced Oct 18, 2024
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Oct 18, 2024
@mergify @kevincai
[BugFix] fix running fragment count during exec env exit (backport #5…
559f258 
…2048) (#52090)

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Co-authored-by: Kevin Cai <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 18, 2024
@mergify @kevincai
[BugFix] fix running fragment count during exec env exit (backport #5…
94c3514 
…2048) (#52089)

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Co-authored-by: Kevin Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@wyb wyb wyb approved these changes

@dirtysalt dirtysalt dirtysalt approved these changes

@trueeyu trueeyu trueeyu approved these changes

Assignees

@kevincai kevincai

Labels
3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevincai @wyb @dirtysalt @trueeyu