Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] support extract common SPJG plan as cte #51808

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Seaven
Copy link
Contributor

@Seaven Seaven commented Oct 11, 2024

Why I'm doing:

What I'm doing:

Extract common SPJG plan

TPCDS 1T EXTRACT CTE BASE RATIO
QUERY09 8460 11069 0.76
QUERY28 4063 10774 0.38
QUERY44 1803 3357 0.54
QUERY65 4710 9316 0.51
QUERY88 2259 15429 0.15
QUERY90 441 789 0.56

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@Seaven Seaven requested review from a team as code owners October 11, 2024 11:48
@mergify mergify bot assigned Seaven Oct 11, 2024
@Seaven Seaven changed the title [Enhancement] support extract common spjg as cte [Enhancement] support extract common SPJG plan as cte Oct 11, 2024
@Seaven Seaven force-pushed the fusion branch 6 times, most recently from 4fd236f to f2e92c9 Compare October 18, 2024 07:05
Copy link

sonarcloud bot commented Oct 18, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 403 / 420 (95.95%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/common/DebugOperatorTracer.java 0 1 00.00% [276]
🔵 com/starrocks/sql/optimizer/rule/tree/pieces/ReuseFusionPlanRule.java 216 231 93.51% [179, 192, 200, 209, 237, 247, 264, 270, 344, 350, 354, 369, 372, 375, 430]
🔵 com/starrocks/sql/optimizer/rule/tree/pieces/QueryPieces.java 18 19 94.74% [47]
🔵 com/starrocks/sql/optimizer/Optimizer.java 12 12 100.00% []
🔵 com/starrocks/sql/optimizer/rule/tree/pieces/LogicalPiecesOperator.java 7 7 100.00% []
🔵 com/starrocks/qe/SessionVariable.java 4 4 100.00% []
🔵 com/starrocks/sql/optimizer/rule/tree/pieces/PiecesPlanTransformer.java 98 98 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/MergeLimitDirectRule.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/rule/RuleType.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/MaterializedViewOptimizer.java 1 1 100.00% []
🔵 com/starrocks/sql/optimizer/rule/tree/pieces/ScalarOperatorConverter.java 25 25 100.00% []
🔵 com/starrocks/analysis/JoinOperator.java 13 13 100.00% []
🔵 com/starrocks/sql/optimizer/rewrite/ReplaceColumnRefRewriter.java 6 6 100.00% []
🔵 com/starrocks/sql/optimizer/operator/OperatorType.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant