Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] When replica enter decommission, transaction will nerver complete. #49349

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

zhangheihei
Copy link
Contributor

@zhangheihei zhangheihei commented Aug 2, 2024

Why I'm doing:

  1. Transaction TA writes to a two-replicas tablet and enters the committed state. The tablet's replica are replicaA, replicaB.
  2. replicaA, replicaB generate tasks: PublishVersionTaskA, PublishVersionTaskB. PublishVersionTaskA/PublishVersionTaskB successfully submitted to the beA/beB via RPC.
  3. The machine where beB is located hangs and is not recoverable. Therefore PublishVersionTaskA is finished,PublishVersionTaskB is unfinished.
  4. FE clone replicaC from replicaA, BE report replicaC info. But transactions must rely on replicaA and replicaB, so TA will block on committed.

What I'm doing:

Fixes #52769

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@zhangheihei zhangheihei requested a review from a team as a code owner August 2, 2024 15:31
Copy link

sonarcloud bot commented Aug 2, 2024

Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei changed the title [Enhancement] When the server machine is not recovered, make transaction to complete in time. [BugFix] When the server machine is not recovered, make transaction to complete in time. Nov 10, 2024
Signed-off-by: edwinhzhang <[email protected]>
@zhangheihei zhangheihei changed the title [BugFix] When the server machine is not recovered, make transaction to complete in time. [BugFix] When the server machine is not recovered, transaction will nerver complete. Nov 10, 2024
@wyb wyb requested a review from luohaha November 21, 2024 05:15
Signed-off-by: edwinhzhang <[email protected]>
Signed-off-by: edwinhzhang <[email protected]>
Signed-off-by: edwinhzhang <[email protected]>
Copy link

sonarcloud bot commented Nov 24, 2024

@zhangheihei zhangheihei changed the title [BugFix] When the server machine is not recovered, transaction will nerver complete. [BugFix] When replica enter decommission, transaction will nerver complete. Nov 24, 2024
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

fail : 25 / 32 (78.12%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/transaction/DatabaseTransactionMgr.java 2 5 40.00% [1100, 1101, 1102]
🔵 com/starrocks/transaction/TransactionState.java 11 14 78.57% [474, 480, 481]
🔵 com/starrocks/transaction/OlapTableTxnLogApplier.java 12 13 92.31% [138]

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When the server machine is not recovered, transaction will nerver complete
4 participants