Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support Query cache in shared_data #42982

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

smartlxh
Copy link
Contributor

@smartlxh smartlxh commented Mar 22, 2024

Why I'm doing:

Support Query cache in shared_data

What I'm doing:

  1. Support lake::TabletReader read delta_rowsets
    Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@smartlxh smartlxh requested review from a team as code owners March 22, 2024 07:49
Copy link

sonarcloud bot commented Apr 8, 2024

yingtingdong
yingtingdong previously approved these changes Apr 8, 2024
be/src/storage/lake/tablet_manager.cpp Outdated Show resolved Hide resolved
be/src/storage/lake/tablet_manager.cpp Outdated Show resolved Hide resolved
@wyb wyb requested a review from satanson April 18, 2024 03:45
@smartlxh smartlxh requested a review from a team as a code owner June 21, 2024 02:48
@smartlxh smartlxh changed the title [Feature] Support Query cache in shared_data [Fnhancement] Support Query cache in shared_data Jun 24, 2024
@smartlxh smartlxh changed the title [Fnhancement] Support Query cache in shared_data [Enhancement] Support Query cache in shared_data Jun 24, 2024
Copy link

sonarcloud bot commented Jun 24, 2024

satanson
satanson previously approved these changes Jul 30, 2024
be/src/storage/lake/tablet_manager.cpp Outdated Show resolved Hide resolved
be/src/storage/lake/tablet_manager.cpp Outdated Show resolved Hide resolved
be/src/exec/pipeline/fragment_executor.cpp Outdated Show resolved Hide resolved
be/src/storage/lake/tablet.h Outdated Show resolved Hide resolved
be/src/storage/lake/tablet.h Show resolved Hide resolved
be/src/exec/query_cache/cache_operator.cpp Outdated Show resolved Hide resolved
satanson
satanson previously approved these changes Oct 11, 2024
smartlxh and others added 24 commits October 19, 2024 00:02
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Signed-off-by: smartlxh <[email protected]>
Copy link

sonarcloud bot commented Oct 19, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 38 / 144 (26.39%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/pipeline/fragment_executor.cpp 0 2 00.00% [485, 486]
🔵 be/src/storage/tablet.cpp 0 1 00.00% [925]
🔵 be/src/storage/lake/tablet_reader.cpp 0 11 00.00% [62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 73]
🔵 be/src/storage/lake/versioned_tablet.cpp 0 8 00.00% [72, 75, 76, 77, 78, 80, 81, 82]
🔵 be/src/connector/lake_connector.cpp 0 2 00.00% [350, 351]
🔵 be/src/storage/lake/rowset.h 0 3 00.00% [123, 126, 127]
🔵 be/src/storage/lake/tablet.h 0 8 00.00% [143, 144, 145, 146, 147, 148, 151, 152]
🔵 be/src/exec/query_cache/cache_operator.cpp 1 71 01.41% [62, 241, 242, 243, 245, 246, 247, 248, 249, 250, 251, 254, 255, 256, 257, 259, 261, 262, 263, 265, 266, 267, 268, 271, 272, 273, 280, 281, 282, 283, 284, 287, 288, 289, 293, 294, 297, 298, 317, 332, 335, 336, 337, 338, 339, 341, 342, 343, 344, 345, 346, 347, 349, 350, 351, 352, 355, 356, 357, 359, 360, 361, 362, 365, 366, 367, 368, 369, 486, 489]
🔵 be/src/storage/lake/tablet_manager.cpp 33 34 97.06% [857]
🔵 be/src/storage/rowset/rowset.h 4 4 100.00% []

Copy link

[FE Incremental Coverage Report]

fail : 1 / 2 (50.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/planner/FragmentNormalizer.java 1 2 50.00% [336]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants