From a61785b63ba19b80b820ab3d8dd6ae40e16ca3e7 Mon Sep 17 00:00:00 2001 From: zombee0 Date: Mon, 14 Oct 2024 11:27:47 +0800 Subject: [PATCH] [BugFix]fix npe issue for external table (#51767) Signed-off-by: zombee0 (cherry picked from commit 067508dbb60a27e69d8608ebe4238ba6ed67f488) --- .../main/java/com/starrocks/sql/analyzer/AnalyzerUtils.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AnalyzerUtils.java b/fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AnalyzerUtils.java index 0df9801d31959..76082943ea6a8 100644 --- a/fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AnalyzerUtils.java +++ b/fe/fe-core/src/main/java/com/starrocks/sql/analyzer/AnalyzerUtils.java @@ -940,6 +940,7 @@ private Table copyTable(Table originalTable) { } } + // The conception is not very clear, be careful when use it. private static class ExternalTableCollector extends TableCollector { List tables; Predicate
predicate; @@ -952,9 +953,7 @@ public ExternalTableCollector(List
tables, Predicate
filter) { @Override public Void visitTable(TableRelation node, Void context) { Table table = node.getTable(); - boolean internal = CatalogMgr.isInternalCatalog(table.getCatalogName()) - || table.isNativeTableOrMaterializedView() - || table.isOlapView(); + boolean internal = table.isNativeTableOrMaterializedView() || table.isOlapView(); if (!internal && predicate.test(table)) { tables.add(table); }