From 7963dd5ebfc90fccb8779cd48d098e599ea2998e Mon Sep 17 00:00:00 2001 From: Binglin Chang Date: Thu, 17 Oct 2024 20:43:14 +0800 Subject: [PATCH] [BugFix] Prevent crash if type mismatch in BinaryDictPageDecoder (#52036) Signed-off-by: Binglin Chang (cherry picked from commit 5f10c07dadd0e59bf8d6bad0eebbd2fb8a2b3f7f) --- be/src/storage/rowset/binary_dict_page.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/be/src/storage/rowset/binary_dict_page.cpp b/be/src/storage/rowset/binary_dict_page.cpp index 0555f93bce1ad..d6731d956ad22 100644 --- a/be/src/storage/rowset/binary_dict_page.cpp +++ b/be/src/storage/rowset/binary_dict_page.cpp @@ -261,7 +261,9 @@ Status BinaryDictPageDecoder::next_batch(const SparseRange& range, Column* } } - CHECK(dst->append_strings_overflow(slices, _max_value_legth)); + bool ok = dst->append_strings_overflow(slices, _max_value_legth); + DCHECK(ok) << "append_strings_overflow failed"; + RETURN_IF(!ok, Status::InternalError("BinaryDictPageDecoder::next_batch failed")); return Status::OK(); }