From 1fa110842bcafdfa54371c9ecb0ca1d35ad182b8 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Thu, 17 Oct 2024 22:33:34 +0800 Subject: [PATCH] [BugFix] Prevent crash if type mismatch in BinaryDictPageDecoder (backport #52036) (backport #52062) (#52068) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> --- be/src/storage/rowset/binary_dict_page.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/be/src/storage/rowset/binary_dict_page.cpp b/be/src/storage/rowset/binary_dict_page.cpp index b7ea8cf10b2fb..d54d8c959903f 100644 --- a/be/src/storage/rowset/binary_dict_page.cpp +++ b/be/src/storage/rowset/binary_dict_page.cpp @@ -261,7 +261,9 @@ Status BinaryDictPageDecoder::next_batch(const SparseRange<>& range, Colum } } - CHECK(dst->append_strings_overflow(slices, _max_value_legth)); + bool ok = dst->append_strings_overflow(slices, _max_value_legth); + DCHECK(ok) << "append_strings_overflow failed"; + RETURN_IF(!ok, Status::InternalError("BinaryDictPageDecoder::next_batch failed")); return Status::OK(); }