Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regent: automatically destroy ispaces, fspaces, regions, partitions #813

Closed
elliottslaughter opened this issue Apr 3, 2020 · 0 comments
Closed
Assignees
Labels
best effort indicates the milestone tag for an issue is a goal rather than a commitment enhancement planned Feature/fix to be actively worked on - needs release target Regent Issues pertaining to Regent
Milestone

Comments

@elliottslaughter
Copy link
Contributor

elliottslaughter commented Apr 3, 2020

Currently Regent leaks ispaces, fspaces, regions and partitions if they are not manually destroyed with __delete. If an application creates any of these dynamically, this turns into a O(N) leak in the length of the run. Ideally Regent should destroy any resources that it creates.

In order to do this correctly, we'll need to do an escape analysis on any objects being returned. As a conservative approximation, anything being packed in an fspace, or anything being directly returned, should be considered to escape. For the moment it's probably ok to let those leak (if the user does not explicitly __delete) since this is an uncommon case.

I have a partial (buggy) solution in branch fix-regent-memory-leaks. At the moment it suffers from double deletions due to #812.

Probably not a direct cause of #711, but worth keeping in mind for that issue.

@elliottslaughter elliottslaughter added enhancement Regent Issues pertaining to Regent planned Feature/fix to be actively worked on - needs release target labels Apr 3, 2020
@elliottslaughter elliottslaughter added this to the 20.06 milestone Apr 3, 2020
@elliottslaughter elliottslaughter self-assigned this Apr 3, 2020
@elliottslaughter elliottslaughter added the best effort indicates the milestone tag for an issue is a goal rather than a commitment label Apr 3, 2020
@elliottslaughter elliottslaughter changed the title Regent: destroy ispaces, fspaces, regions, partitions Regent: automatically destroy ispaces, fspaces, regions, partitions Apr 3, 2020
@streichler streichler modified the milestones: 20.06, 20.09 Sep 9, 2020
@streichler streichler modified the milestones: 20.09, 20.12 Oct 1, 2020
@streichler streichler modified the milestones: 20.12, 21.03 Dec 27, 2020
@elliottslaughter elliottslaughter modified the milestones: 21.03, 21.09 Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best effort indicates the milestone tag for an issue is a goal rather than a commitment enhancement planned Feature/fix to be actively worked on - needs release target Regent Issues pertaining to Regent
Projects
None yet
Development

No branches or pull requests

2 participants