Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: test with LEGION_GC #732

Open
elliottslaughter opened this issue Jan 28, 2020 · 2 comments
Open

CI: test with LEGION_GC #732

elliottslaughter opened this issue Jan 28, 2020 · 2 comments
Assignees
@elliottslaughter
Labels
best effort indicates the milestone tag for an issue is a goal rather than a commitment CI Issues pertaining to continuous integration enhancement planned Feature/fix to be actively worked on - needs release target

Comments

@elliottslaughter
Copy link
Contributor

We might have caught #711 earlier if we'd actually had this test.

Need to build with -DLEGION_GC, run with -level legion_gc=2 -logfile gc_%.log, analyze with legion_gc.py -cl gc_0.log. Should work pretty similarly to our Legion Spy tests.
@elliottslaughter elliottslaughter added enhancement planned Feature/fix to be actively worked on - needs release target CI Issues pertaining to continuous integration labels Jan 28, 2020
@elliottslaughter elliottslaughter added this to the 20.03 milestone Jan 28, 2020
@elliottslaughter elliottslaughter self-assigned this Jan 28, 2020
@elliottslaughter
Copy link
Contributor Author

The first part of this went in with 0940e8e, but we're leaking enough via #711 (and possibly other bugs) that it's not worth turning on yet. We'll have to wait for that to be fixed before we can seriously consider this.

@magnatelee
Copy link
Contributor

I confirmed that the fix for #711 has eradicated future leaks in all of our test cases. However, many tests are still leaking layout constraints and index spaces (#606).

@elliottslaughter elliottslaughter modified the milestones: 20.03, 20.06 Mar 20, 2020
@elliottslaughter elliottslaughter added the best effort indicates the milestone tag for an issue is a goal rather than a commitment label Apr 3, 2020
@streichler streichler modified the milestones: 20.06, 20.09 Sep 9, 2020
@streichler streichler modified the milestones: 20.09, 20.12 Oct 1, 2020
@streichler streichler modified the milestones: 20.12, 21.03 Dec 27, 2020
@elliottslaughter elliottslaughter modified the milestones: 21.03, 21.09 Jun 15, 2021
@elliottslaughter elliottslaughter removed this from the 21.09 milestone Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elliottslaughter elliottslaughter

Labels
best effort indicates the milestone tag for an issue is a goal rather than a commitment CI Issues pertaining to continuous integration enhancement planned Feature/fix to be actively worked on - needs release target
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elliottslaughter @magnatelee @streichler