Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realm: compile time error in shm.cc #1589

Closed
Tracked by #1032
mariodirenzo opened this issue Nov 6, 2023 · 4 comments
Closed
Tracked by #1032

Realm: compile time error in shm.cc #1589

mariodirenzo opened this issue Nov 6, 2023 · 4 comments

Comments

@mariodirenzo
Copy link

Hello, the latest version of control replication fails to compile on one of the computers that use for CI of HTR with the following error:

/home/gitlab-runner/legion/runtime/realm/shm.cc: In static member function 'static bool Realm::SharedMemoryInfo::create(Realm::SharedMemoryInfo&, size_t, const char*, int)':
/home/gitlab-runner/legion/runtime/realm/shm.cc:104:42: error: 'MFD_CLOEXEC' was not declared in this scope; did you mean 'FD_CLOEXEC'?
  104 |       fd = syscall(SYS_memfd_create, "", MFD_CLOEXEC);
      |                                          ^~~~~~~~~~~
      |                                          FD_CLOEXEC
make[2]: *** [runtime/CMakeFiles/RealmRuntime.dir/realm/shm.cc.o] Error 1
make[1]: *** [runtime/CMakeFiles/RealmRuntime.dir/all] Error 2
make: *** [all] Error 2

At a first look, this seems related to the latest changes to the shared memory management

@elliottslaughter, can you please add this issue to #1032 with high priority?

@elliottslaughter
Copy link
Contributor

@muraj is this yours?

@cmelone
Copy link
Contributor

cmelone commented Nov 6, 2023

I will add that this is the second compilation error uncovered by our CI in the past few days.

@muraj
Copy link

muraj commented Nov 6, 2023

Yeah, this is actually older and related to the first one in that conda compilers seem to have a weird libc implementation. I pushed a change to master to fix this, should be okay now.

@mariodirenzo
Copy link
Author

Thanks for working on a fix. The issue is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants