Skip to content
This repository has been archived by the owner on Mar 26, 2020. It is now read-only.

PHANTOMJS_VERSION = '<2.0.0' #12

Open
itpmngt opened this issue May 24, 2015 · 3 comments
Open

PHANTOMJS_VERSION = '<2.0.0' #12

itpmngt opened this issue May 24, 2015 · 3 comments

Comments

@itpmngt
Copy link

itpmngt commented May 24, 2015

Lotte is expecting PhantomJS to be above 2.0.0 but PhantomJS is at =2.0.0 instead of <2.0.0

line 3
const PHANTOMJS_VERSION = '<2.0.0'

@StanAngeloff
Copy link
Owner

Hey,

Thanks for reporting this. I haven't tested against PhantomJS 2.0.0. What happens if you update the line to >= 2.0.0, does that work for you?

@itpmngt
Copy link
Author

itpmngt commented May 25, 2015

Yes, that was my fix.

BTW, is it imperative to use 2.0.0? I am asking because other frameworks (casper.js) use below 2.0.0 so for me it needs to replace phantomjs to switch between both

@StanAngeloff
Copy link
Owner

If your tests work on PhantomJS 2.x then that means Lotte is compatible with that version of PhantomJS. I haven't personally tested with anything above 1.9, however it appears from what you are saying that tests run and complete successfully on 2.x?

EDIT: You can also use --no-verify on the command line to skip PhantomJS version checks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants