-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicated Nested Close Buttons after update #235
Comments
I think it will be great to set a new optional |
Correct, in 11.0.0 styles and layout were reworked to create more consistent layout across devices. It also cuts down on the amount of boilerplate magic string content that needs to be provided just to add a button. It looks like some of the documentation incorrectly still suggests adding explicit However, this doesn't solve the issue of binding aria-label and/or classes. I think your idea of an input binding @skrzepij should work and I'll look into getting that change in soon. |
I have overrided close button html. In version 8.0.0 generated code was looking fine.
After update to newest version 11.0.1 that was needed to update Angular, generated code looks different.
Now my custom close button is wrapped by generated button element.
The text was updated successfully, but these errors were encountered: