Switch to kotlin.reflect.typeOf for configurate-extra-kotlin
#422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We aren't planning on bumping the minimum kotlin version |
|
What's the reason for that? I get why one would stay on older java versions, but I don't see a reason to stay on an old Kotlin version, because kotlin-stdlib is just a dependency. I'm also not aware of any breaking changes since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests fixes #420 by replacing all
typeTokenOf<T>()calls in theconfigurate-extra-kotlinmodule withtypeOf<T>().javaTypeand also adds extension functions forKType.I've also had to update Kotlin to
1.8.20becausetypeOf()was experimental on the previous Kotlin version and added/changed some methods in the core module to also acceptjava.lang.reflect.Typeinstead of justTypeTokenandClass.I'm aware that this PR currently fails detekt tests, as
ConfigurationNodeExtensions.ktnow has 22/20 methods, but I don't see how (and why) one would split that file.