Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning message: Dto\ResourceCache" class is considered final. #170

Open
tacman opened this issue Apr 13, 2024 · 2 comments
Open

Warning message: Dto\ResourceCache" class is considered final. #170

tacman opened this issue Apr 13, 2024 · 2 comments

Comments

@tacman
Copy link
Contributor

tacman commented Apr 13, 2024

Version(s) affected

1.2.x

Description

1x: The "SpomkyLabs\PwaBundle\Dto\ResourceCache" class is considered final. It may change without further notice as of its next major version. You should not extend it from "SpomkyLabs\PwaBundle\Dto\PageCache".
1x in AllRoutesTest::testRoutesDoNotReturnInternalError from App\Tests

How to reproduce

I saw this when running phpunit in an application that uses the bundle.

Possible Solution

remove final from Dto\ResourceCache"?

Additional Context

No response

@Spomky
Copy link
Member

Spomky commented Apr 13, 2024

Hi @tacman,

ResourceCache will replace PageCache That is final too. There is no reason to extend those classes are thay are used internaly and generated from the configuration (resource_cache).
You can safely ignore this warning as long as you do not extend it.

@tacman
Copy link
Contributor Author

tacman commented May 10, 2024

Right, but the deprecation messages are showing up in the logs. Since PageCache does extend ResourceCache, it shouldn't be marked as final, right?

[Application] May 10 15:20:10 |INFO | DEPREC User Deprecated: The "SpomkyLabs\PwaBundle\Dto\ResourceCache" class is considered final. It may change without further notice as of its next major version. You should not extend it from "SpomkyLabs\PwaBundle\Dto\PageCache".
[Application] May 10 15:20:10 |INFO | DEPREC User Deprecated: The "SpomkyLabs\PwaBu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants