Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the data from minecraft-data #57

Closed
Gjum opened this issue Mar 25, 2015 · 7 comments
Closed

Use the data from minecraft-data #57

Gjum opened this issue Mar 25, 2015 · 7 comments

Comments

@Gjum
Copy link
Member

Gjum commented Mar 25, 2015

Add minecraft-data as a submodule.
Can be used for recipes right now, later for more stuff (e.g. generate block/biome info or item info, which is needed for Inventory).

@Gjum
Copy link
Member Author

Gjum commented Mar 25, 2015

What about just adding a script that clones the minecraft-data repo, generates class definitions and converts some structs to Python source (s/null/None/g, recipes = {...}) instead of JSON?

@rom1504
Copy link
Member

rom1504 commented Mar 26, 2015

That still leave some data duplication but at least that way you can update to new minecraft-data versions by just updating the minecraft-data commit SHA you use and running that script.

@Gjum Gjum self-assigned this Aug 14, 2015
@Gjum
Copy link
Member Author

Gjum commented Aug 21, 2015

@nickelpro
Copy link
Member

I'm waiting on a more suitable protocol schema, see PrismarineJS/minecraft-data#27 (comment)

@Gjum
Copy link
Member Author

Gjum commented Sep 7, 2015

windows.json (25b7b8f) and recipes.json (796fd41) are used now.

@Gjum
Copy link
Member Author

Gjum commented Sep 9, 2015

There should be separate issues to track all the the single modules that need to be done.

@Gjum Gjum removed their assignment Sep 9, 2015
@gamingrobot
Copy link
Member

Issues created see #123 #124 #125 #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants