Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it be possible to create a pip installation? #17

Closed
LastedApple3 opened this issue Apr 20, 2021 · 2 comments
Closed

Would it be possible to create a pip installation? #17

LastedApple3 opened this issue Apr 20, 2021 · 2 comments

Comments

@LastedApple3
Copy link

Though the instructions in the docs could be quite useful, it would be simpler if there was a pip installation.
I do not have the capability to run the setup described in the docs, and I'm sure others don't either, so if it were pre-setup, and all you have to do is run the pip install, it would increase the availability.

@nickelpro
Copy link
Member

Unfortunately while Python is prominent in RikerBot, it's really a C++ project as far as build process goes. While it is possible to teach pip to build the project, very little would be gained in simplicity because it would simply be running the required cmake command for you. None of the build requirements would change and if your system isn't set up to use the existing build process pip would fail too. For now, I think requiring users to invoke cmake specifically signposts these requirements.

Eventually it may be possible to upload a binary wheel to PyPI for Windows, so that Windows users could side-step this process. That would require a working Windows build, which would require fixing #10. Getting CI working on Windows to produce the binaries is non-trivial and not really in my skillset, I did try for a couple hours one weekend, if anyone is a Github actions wizard and can get that process working I would certainly appreciate it and would happily start doing PyPI uploads.

nickelpro added a commit that referenced this issue May 3, 2021
nickelpro added a commit that referenced this issue May 3, 2021
@nickelpro
Copy link
Member

This is fixed, pip can now run cmake and build RikerBot. Note that none of the build requirements have changed, you can just build the project via invoking pip instead of cmake if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants