Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement experiment layer delay override #31

Closed
sebjameswml opened this issue Nov 14, 2016 · 4 comments
Closed

Implement experiment layer delay override #31

sebjameswml opened this issue Nov 14, 2016 · 4 comments
Assignees
@sebjameswml

Comments

@sebjameswml
Copy link
Collaborator

Just as you can override a model Property via the experiment layer, you should be able to override the delay.

This is fairly easy for FixedValue delays; see branch expt_delay_change_option for the code.

However, this has flagged up that we don't seem to support Uniform or Normal distribution delays; will create a ticket for that, too.
@sebjameswml
Copy link
Collaborator Author

Fix Issue:30 while fixing this code, so I don't have to find my way around this code twice.

@sebjameswml sebjameswml self-assigned this Nov 14, 2016
@sebjameswml sebjameswml mentioned this issue Nov 14, 2016
Open
@sebjameswml
Copy link
Collaborator Author

See commits 3df9037 cce5b2c and 85d778a for a first pass at this feature.

@sebjameswml
Copy link
Collaborator Author

The implementation that's now in master needs to be updated to match the proposal for delay changes in SpineML, see SpineML/spineml#5 for details.

@sebjameswml
Copy link
Collaborator Author

Implementation now matches proposed SpineML spec. See e96b90b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebjameswml sebjameswml

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebjameswml