-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unable to detect channels outside of brain with detect_bad_channels
#2929
Comments
we are at a hackathon right now for spikeinterface. We will try to get to this soon! Ping us again Monday if we haven't responded before then, please! |
hello again guys, any update on this? |
Thanks @a-zmz, this is interesting, Can I confirm, when you supply the raw data the bad channel detection works well, but if you bandpass filter the data, then it does not work? This actually may not be so suprising, the data must be filtered for bad channel detection to work. If raw data is passed, it will be filtered internally in the function. Both this internal filtering (and the filtering applied in the IBL pipeline from which this is ported) are highpass filters. It may be that the bandpass filter is removing high frequencies that would indicate these are noisy channels in the ibl function. Out of interst, could you see if, when the detection is working, these channels are labelled as noisy (2) or out of brain (3)? I think if it is working without bandpass filtering, I would detect bad channels on the 'raw' data (technically, on the highpass filtered data under the hood) and then do bandpass filtering. This is a point for #2996, in general it is probably not idea to perform detect bad channels after bandpass filtering? @oliche may be able to comment better. |
hello @JoeZiminski, yea i realised the highpass filtering in the bad channel detection function. When passing raw to the function, i got those channels are labelled as re question about detecting
|
The depths of the channels are used already, so top and bottom refer to the physical locations, not the channel indices ;) |
oh right i see, then i should just use |
yes |
Hi,
I tried to remove bad channels of my neuropixels 1.0 data, and the
detect_bad_channels
function could not detect any channels outside of brain no matter parameters...key questions:
outside_channels_location
?ps. running spikeinterface v0.101.0 on linux fedora 39
Thanks!
The text was updated successfully, but these errors were encountered: