Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Templates dataclass #1978

Closed
h-mayorquin opened this issue Sep 11, 2023 · 4 comments
Closed

Create Templates dataclass #1978

h-mayorquin opened this issue Sep 11, 2023 · 4 comments
Assignees
Labels
hybrid Related to Hybrid testing

Comments

@h-mayorquin
Copy link
Collaborator

Simple dataclass for templates, including:

  • ms_before/after
  • nbefore/after
  • channel_ids/unit_ids
  • channel_locations
  • sparsity

Needs to be picklable and JSON-serializable

@h-mayorquin h-mayorquin self-assigned this Sep 11, 2023
@CodyCBakerPhD
Copy link
Collaborator

Needs to be picklable and JSON-serializable

Going with a Pydantic Model would go a long way beyond a traditional dataclass towards helping with these, as well as auto-generation of the accompanying JSON schema (not to mention native type checking / input validation)

@h-mayorquin
Copy link
Collaborator Author

Thanks, Cody. I personally would like to play to it. But I think that @samuelgarcia does not want to add any other dependency to the core? Am I wrong?

What do you guys think @samuelgarcia @alejoe91.

@alejoe91
Copy link
Member

Yeah for the first round this will be mainly used internally, so I think that pydantic might bean overkill. Let's keep this in mind for future developments.

@alejoe91 alejoe91 added the hybrid Related to Hybrid testing label Sep 12, 2023
@h-mayorquin
Copy link
Collaborator Author

#1982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hybrid Related to Hybrid testing
Projects
None yet
Development

No branches or pull requests

3 participants