Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor (Item without Value) #1233

Open
Steinny opened this issue Apr 10, 2024 · 10 comments
Open

Vendor (Item without Value) #1233

Steinny opened this issue Apr 10, 2024 · 10 comments

Comments

@Steinny
Copy link

Steinny commented Apr 10, 2024

If item in sell list of vendor has no price. (It is a mistake in the default scripts)
price set as 1825361101
and the order of the goods list is also broken

@xwerswoodx
Copy link
Contributor

I haven't got the issue, if you think there is a missing code in scripts, you need to open this issue in Scripts-X. If you give an example of the issue, we can take a look.

@Jhobean
Copy link
Contributor

Jhobean commented Apr 10, 2024

On my side I removed the value of an item
image

I use Orion. Value is set to 43 by default.. I don't know why. But its not 1825361101

@Steinny
Copy link
Author

Steinny commented Apr 11, 2024

c_scribe - price of books
SELL=i_book_sm,{5 10}
SELL=i_book_lg,{5 10}

@xwerswoodx
Copy link
Contributor

Maybe there is a misunderstanding, {5 10} is not a price, it's an amount of item can be sold by vendor, in this example {5 10} means it will sell random value from 5 to 10. Like it can sell 7 i_book_sm or next time it restocked it can be 6, 9, 10 etc. Prices comes from VALUE if TAG.OVERRIDE.VALUE isn't set for item.

@Steinny
Copy link
Author

Steinny commented Apr 21, 2024

I know what it is.
{5 10}

[ITEMDEF 0ff1]
DEFNAME=i_book_sm
TYPE=t_book
CATEGORY=Items by Professions
SUBSECTION=Scribe
DESCRIPTION=Dark Brown Book

Screenshot_2

@canerksk
Copy link
Contributor

canerksk commented Apr 22, 2024

This was always the case with the X1 version, but an item that was not previously entered would not appear in the vendor and would give a console warning “ non-vendable items”

@xwerswoodx
Copy link
Contributor

xwerswoodx commented Apr 22, 2024

This was always the case with the X1 version, but an item that was not previously entered would not appear in the vendor and would give a console warning “ non-vendable items”

There is a vendable item class but could you give me an example, because I haven't got what you mean with "item that was not previously entered" while you have to set sell and buy menus statically in script.

@Steinny
Copy link
Author

Steinny commented Apr 23, 2024

I didn't do anything. I just downloaded the scripts

c_scribe_f

of course, we can just agree that this needs to be fixed in the scripts.

@canerksk
Copy link
Contributor

canerksk commented Apr 28, 2024

This was always the case with the X1 version, but an item that was not previously entered would not appear in the vendor and would give a console warning “ non-vendable items”

There is a vendable item class but could you give me an example, because I haven't got what you mean with "item that was not previously entered" while you have to set sell and buy menus statically in script.

Normalde bir eşyaya hiç value değeri verilmemiş (value=0 girilmesi hariç) bir itemin altında hiç bir şekilde value yazmıyor ise (yukarda verilen book scpsi gibi) o eşya vendorda listelenmeye çalıştığında (tam emin değilim, satış layerine eklendiğinde de olabilir) “bu eşya satılabilen bir eşya değil” gibi bir uyarı verip satış listesine hiç eklemiyor/göstermiyordu ama şu an bir eşyaya hiç bir value değeri belirtmediği zaman yukardakş görselde belirtildiği üzere vendor listesine eklediği gibi bir de anlamsız satış fiyatı gösteriyor veya set ediyor.

@Tolokio
Copy link
Contributor

Tolokio commented Aug 28, 2024

On my side I removed the value of an item image

I use Orion. Value is set to 43 by default.. I don't know why. But its not 1825361101

Could be that price taken from tiledata?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants