-
Notifications
You must be signed in to change notification settings - Fork 25
OpenID4VP ID1 + JWT VC Presentation Profile #29
Comments
Hi @siacomuzzi Yes on both accounts. We are working on both of these. In https://github.com/Sphereon-Opensource/did-auth-siop/tree/release/v2.0.0 you can see some things landing for the VC Presentation Profile, like domain linkage etc. The OID4VP work is just starting at this point, but we need something concrete to show interop over the next few weeks, so we will have something pretty fast. |
Thank you @nklomp! I just installed that branch in my webapp:
But it's looks like the build script is not executed: Am I missing something? |
Yeah, unfortunately the name of the branch is a bit off. There is no release yet of that version. You could build it locally I guess. We will soon merge it. |
I was able to build it locally:
But, after link the module into my webapp (
|
Hmzz, could you try out this version? I build it from the v2 branch just now. If that yields the same results, could you provide you tsconfig and node/typescript versions? |
|
nvm, |
Hehe probably you were too fast. Sometimes it takes a bit. But indeed..1 also works. It only misses the last merge from today |
It's working now, thank you for publishing it!
|
Thanks for the valuable feedback. We will definitely address these. This lib predates the jwt-vc interop profile and was based on older SIOPv2 and OIDC4VP specs. Hence there are still some incompatibilities. We certainly will make it compatible with the interop profile, since we need it ourselves as well ;) CC @sksadjad @BtencateSphereon @maikel-maas |
Regarding 3. It seems like we are now in a situation, where the latest SIOPV2 spec, ditched the value altogether and the JWT VC Interop profile using a different value than the SIOPv2 Implementors Draft 1 version it was based on. I asked for clarification. I asked for clarification in the interop profile Github: decentralized-identity/jwt-vc-presentation-profile#63 |
Regarding 1. I think this is an error in the interop profile example. The schema comes from Presentation Exchange v1 specification and it quite clearly should be a URI. It also doesn't make much sense to me to have a simple string instead of a URI for what is supposed to link a schema. I have created a ticket in the interop github for clarification: decentralized-identity/jwt-vc-presentation-profile#64 |
Please note that the So something like |
Hi,
Is there a workaround for this? - BTW I'm using the latest version Thanks, |
Hi @embesozzi. We are going to support strings as well, to ensure interop. We have this on our backlog together with some changes we need to make to the lower level Presentation Exchange at a later point. But let me expedite this a bit, as it should be a simple change on our end. |
The 0.3.0-unstable.2 release now supports strings for Leaving this open for now, as there probably will be some more issues with Entra compatibility. We will soon write some integration and regression tests for entra and ID1. |
Hi @nklomp, first of all thanks for your quick fix. Great work guys ! 👏 |
Cool, thanks for the feedback @embesozzi! I was expecting some issues with some of the discovery metadata, as we still have some work to do there. Will keep this ticket open to update for changes and keep track whether everything still works for ID1 (and entra) |
Hi,
Do you have plans to support
OpenID4VP ID1
/JWT VC Presentation Profile
spec?I know that there are a lot of specifications and different versions about that, but it seems like this specific one is used by Microsoft Entra.
Thank you
The text was updated successfully, but these errors were encountered: