Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the issuer demo #94

Open
ThierryThevenet opened this issue Dec 18, 2023 · 4 comments
Open

Question about the issuer demo #94

ThierryThevenet opened this issue Dec 18, 2023 · 4 comments

Comments

@ThierryThevenet
Copy link

ThierryThevenet commented Dec 18, 2023

Hello,
On https://ssi.sphereon.com/demo/issuer/
I see in the credential offer a and an array of string

{
  "grants": {
    "urn:ietf:params:oauth:grant-type:pre-authorized_code": {
      "pre-authorized_code": "hTJJAbnSdRi5fK1z46imAV",
      "user_pin_required": false
    }
  },
  "credentials": [
    "DBCGuest"
  ],

but the DBCGuest is not used as the "id" in the credential supported section which is my interpretation of the draft 11, credential offer
If the entry is a string, the string value MUST be one of the id values in one of the objects in the credentials_supported Credential Issuer metadata parameter. When processing, the Wallet MUST resolve this string value to the respective object.

@ThierryThevenet ThierryThevenet changed the title Quetsion about the issuer of DBC Question about the issuer of DBC Dec 18, 2023
@ThierryThevenet ThierryThevenet changed the title Question about the issuer of DBC Question about the issuer demo Dec 18, 2023
@nklomp
Copy link
Contributor

nklomp commented Dec 19, 2023

Hi @ThierryThevenet

This was indeed a misconfiguration in the metadata which has been fixed. It worked with our wallet, because we also match against the types and add VerifiableCredential as a fallback for the matching logic.

Now the wallet gets the credential, but afterwards the DID resolution fails. I am assuming it has to do with the version of the wallet in the store for did:jwk, but happy to hear if it is something else of course

@ThierryThevenet
Copy link
Author

ThierryThevenet commented Dec 21, 2023

Hello,
ok I understand.
there are still differences -> OpenBadgeCredential vs OpenbadgeCredentialJwt, etc same for others
and unfortunately our wallet does only fetch against the types when an object is used in the offer like EBSI does. We have also solved some issues in our side thanks to your issuer.

@nklomp
Copy link
Contributor

nklomp commented Dec 21, 2023

Okay thanks. We should have looked at the other credentials as well. Will do so tomorrow

@ThierryThevenet
Copy link
Author

ThierryThevenet commented Dec 22, 2023

Hello, back again to bother you...
this is the credential received from the issuer of the Dutch Blockchain Coalition "DBCConferenceAttendee"

The format is a bit different from usual for our wallet, but main issue is that we do not find a "jti" or a "vc.id" .
Is that normal here ?

eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9.eyJleHAiOjE3MDU5MTExOTUsInZjIjp7IkBjb250ZXh0IjpbImh0dHBzOi8vd3d3LnczLm9yZy8yMDE4L2NyZWRlbnRpYWxzL3YxIl0sInR5cGUiOlsiVmVyaWZpYWJsZUNyZWRlbnRpYWwiLCJEQkNDb25mZXJlbmNlQXR0ZW5kZWUiXSwiY3JlZGVudGlhbFN1YmplY3QiOnsiZmlyc3ROYW1lIjoiQmliYXNoIiwibGFzdE5hbWUiOiJTaHJlc3RoYSIsImVtYWlsIjoiYmliYXNoc2hyZXN0aGFAZ21haWwuY29tIiwiZXZlbnQiOnsibmFtZSI6IkRCQyBDb25mZXJlbmNlIDIwMjMiLCJkYXRlIjoiMjAyMy0wNi0yNiJ9LCJpZCI6ImRpZDpqd2s6ZXlKamNuWWlPaUpRTFRJMU5pSXNJbXQwZVNJNklrVkRJaXdpZUNJNkltSlVSbEUyU0RsbU4waHROelZXTUdneFEwcE9jbXd4T0VJeGJrUnFTRkY0YWs5SFJucEtTVVZCZHpBaUxDSjVJam9pTXpKM09Wb3RhMlI1Vm5GNmEzZ3pZV2gyZUhoNldqSTBVR05QV0c1ME4xUllTbEZOYkUwNE1GZDVVU0o5In19LCJAY29udGV4dCI6WyJodHRwczovL3d3dy53My5vcmcvMjAxOC9jcmVkZW50aWFscy92MSJdLCJ0eXBlIjpbIlZlcmlmaWFibGVDcmVkZW50aWFsIiwiREJDQ29uZmVyZW5jZUF0dGVuZGVlIl0sImV4cGlyYXRpb25EYXRlIjoiMjAyNC0wMS0yMlQwODoxMzoxNS45MDBaIiwiY3JlZGVudGlhbFN1YmplY3QiOnsiZmlyc3ROYW1lIjoiQmliYXNoIiwibGFzdE5hbWUiOiJTaHJlc3RoYSIsImVtYWlsIjoiYmliYXNoc2hyZXN0aGFAZ21haWwuY29tIiwiZXZlbnQiOnsibmFtZSI6IkRCQyBDb25mZXJlbmNlIDIwMjMiLCJkYXRlIjoiMjAyMy0wNi0yNiJ9LCJpZCI6ImRpZDpqd2s6ZXlKamNuWWlPaUpRTFRJMU5pSXNJbXQwZVNJNklrVkRJaXdpZUNJNkltSlVSbEUyU0RsbU4waHROelZXTUdneFEwcE9jbXd4T0VJeGJrUnFTRkY0YWs5SFJucEtTVVZCZHpBaUxDSjVJam9pTXpKM09Wb3RhMlI1Vm5GNmEzZ3pZV2gyZUhoNldqSTBVR05QV0c1ME4xUllTbEZOYkUwNE1GZDVVU0o5In0sImlzc3VlciI6ImRpZDpqd2s6ZXlKaGJHY2lPaUpGVXpJMU5pSXNJblZ6WlNJNkluTnBaeUlzSW10MGVTSTZJa1ZESWl3aVkzSjJJam9pVUMweU5UWWlMQ0o0SWpvaVZFY3lTREo0TW1SWFdFNHpkVU54V25CeFJqRjVjMEZRVVZaRVNrVk9YMGd0UTAxMFltZHFZaTFPWnlJc0lua2lPaUk1VFRoT2VHUXdVRTR5TWswNWJGQkVlR1J3UkhCdlZFeDZNVFYzWm5sYVNuTTJXbWhMU1ZWS016TTRJbjAiLCJpc3N1YW5jZURhdGUiOiIyMDIzLTEyLTIyVDA4OjEzOjE1LjkwMFoiLCJzdWIiOiJkaWQ6andrOmV5SmpjbllpT2lKUUxUSTFOaUlzSW10MGVTSTZJa1ZESWl3aWVDSTZJbUpVUmxFMlNEbG1OMGh0TnpWV01HZ3hRMHBPY213eE9FSXhia1JxU0ZGNGFrOUhSbnBLU1VWQmR6QWlMQ0o1SWpvaU16SjNPVm90YTJSNVZuRjZhM2d6WVdoMmVIaDZXakkwVUdOUFdHNTBOMVJZU2xGTmJFMDRNRmQ1VVNKOSIsIm5iZiI6MTcwMzIzMjc5NSwiaXNzIjoiZGlkOmp3azpleUpoYkdjaU9pSkZVekkxTmlJc0luVnpaU0k2SW5OcFp5SXNJbXQwZVNJNklrVkRJaXdpWTNKMklqb2lVQzB5TlRZaUxDSjRJam9pVkVjeVNESjRNbVJYV0U0emRVTnhXbkJ4UmpGNWMwRlFVVlpFU2tWT1gwZ3RRMDEwWW1kcVlpMU9aeUlzSW5raU9pSTVUVGhPZUdRd1VFNHlNazA1YkZCRWVHUndSSEJ2VkV4Nk1UVjNabmxhU25NMldtaExTVlZLTXpNNEluMCJ9.OWPGUbix76BN-KYsNO7pc0Tabur_yoACPoHXAlOwDLN3fsSUFShAhHAiXrF6NDbrGHm5ELRDz-4g_6Kchrh9hQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants