[feature request] Make logging part configurable

[jcyuan]

something like

public interface ILogSink
{
    bool IsEnabled(LogEventLevel level, string type);
    void Log(LogEventLevel level, string type, object? source, string messageTemplate);
    void Log(
      LogEventLevel level,
      string type,
      object? source,
      string messageTemplate,
      params object?[] propertyValues);
  }

and in SeeShark have a default console sink and then in the end user logic just implement a sink adapter and replace the default one to record logs.

[Speykious]

So it's about bringing customizability here?

SeeShark/SeeShark/FFmpeg/FFmpegManager.cs

Lines 102 to 126 in cc4aa3b

	internal static unsafe void SetupFFmpegLogging(FFmpegLogLevel logLevel, ConsoleColor logColor)
	{
	ffmpeg.av_log_set_level((int)logLevel);
	// Do not convert to local function!
	logCallback = (p0, level, format, vl) =>
	{
	if (level > ffmpeg.av_log_get_level())
	return;
	var lineSize = 1024;
	var lineBuffer = stackalloc byte[lineSize];
	var printPrefix = 1;
	ffmpeg.av_log_format_line(p0, level, format, vl, lineBuffer, lineSize, &printPrefix);
	var line = Marshal.PtrToStringAnsi((IntPtr)lineBuffer);
	// TODO: maybe make it possible to log this in any stream?
	Console.ForegroundColor = logColor;
	Console.Write(line);
	Console.ResetColor();
	};
	ffmpeg.av_log_set_callback(logCallback);
	}

[jcyuan]

So it's about bringing customizability here?

SeeShark/SeeShark/FFmpeg/FFmpegManager.cs

Lines 102 to 126 in cc4aa3b

	internal static unsafe void SetupFFmpegLogging(FFmpegLogLevel logLevel, ConsoleColor logColor)
	{
	ffmpeg.av_log_set_level((int)logLevel);
	// Do not convert to local function!
	logCallback = (p0, level, format, vl) =>
	{
	if (level > ffmpeg.av_log_get_level())
	return;
	var lineSize = 1024;
	var lineBuffer = stackalloc byte[lineSize];
	var printPrefix = 1;
	ffmpeg.av_log_format_line(p0, level, format, vl, lineBuffer, lineSize, &printPrefix);
	var line = Marshal.PtrToStringAnsi((IntPtr)lineBuffer);
	// TODO: maybe make it possible to log this in any stream?
	Console.ForegroundColor = logColor;
	Console.Write(line);
	Console.ResetColor();
	};
	ffmpeg.av_log_set_callback(logCallback);
	}

yes please, because i need to record informations into log files.
not sure why public interface ILogSink this line was missed in my code above. just fixed.
so that in my logic i can do something like:

class SerilogLoggerAdapter : ILogSink {
      public SerilogLoggerAdapter(ILogger logger)
    {
        _log = logger;
    }
    public bool IsEnabled(LogEventLevel level, string area) { ... return true; }
    public void Log(LogEventLevel level, string area, object? source, string messageTemplate)
    {
       switch(level) case LogEventLevel.Debug: _log.Debug(.....); .....
    }
    .....
}

// then maybe:
YourLibModule.SetLoggerSink(new SerilogLoggerAdapter(new Serilog.LoggerConfig().WriteToFile().CreateLogger()));

[Speykious]

Ok, I'll see what I can do. Ideally you'll just need to setup a delegate, no need to create an interface.

[jcyuan]

Ok, I'll see what I can do. Ideally you'll just need to setup a delegate, no need to create an interface.

ok~ it works too, but not sure which way will be more efficient, but i think it's ignorable.
and thanks so much~ 👍

[jcyuan]

ah, right, another is, could you please make the paths configurable too?

SeeShark/SeeShark/Device/VideoDeviceManager.cs

Lines 52 to 55 in cc4aa3b

	protected VideoDeviceManager(DeviceInputFormat inputFormat)
	{
	SetupFFmpeg();

[Speykious]

Not sure what you mean, path to what?
If it's for the logging file, then you're gonna specify it yourself anyway, no problem :p

[jcyuan]

i'm sorry, it's a public static method. my bad.😅

[jcyuan]

Not sure what you mean, path to what? If it's for the logging file, then you're gonna specify it yourself anyway, no problem :p

no no, i meant, i thought FFmpegManager.SetupFFmpeg is internal use only, i found it in VideoManager class, and i wanna pass my path into it.
but i just found FFmpegManager.SetupFFmpeg is a static public method, so i can just call it when my app booting up.
no worry, this is not related to the logging problem.
sorry just ignore it.

[jcyuan]

are these native libs any special? or just download from ffmpeg official site it will just work fine?
which version your lib is currently rely on?

[Speykious]

SeeShark 4 relies on the FFmpeg 5.0 LibAV* native libraries. In any case, if the versions aren't correct, it's going to tell you.
So yeah you can just download them from the official website. But you need the libav dynamic libraries, not the ffmpeg executable.

[jcyuan]

SeeShark 4 relies on the FFmpeg 5.0 LibAV* native libraries. In any case, if the versions aren't correct, it's going to tell you. So yeah you can just download them from the official website. But you need the libav dynamic libraries, not the ffmpeg executable.

nice one, thanks so much ❤️