Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number format flexibility with set! #634

Merged
merged 7 commits into from
Dec 14, 2024
Merged

Number format flexibility with set! #634

merged 7 commits into from
Dec 14, 2024

Conversation

rocroc2017
Copy link
Contributor

1，modified: src/SpeedyTransforms/spectral_transform.jl

# add eltype 2024.12.12 by roc
Base.eltype(S::SpectralTransform{NF}) where NF = NF # 2024.12.12 by roc

2，modified: src/dynamics/prognostic_variables.jl

    grids = convert.(eltype(S), grids)  #change in 2024.12.12 by roc

@milankl milankl added bug 🐞 Something isn't working initial conditions 🚥 Initial conditions of model simulations labels Dec 12, 2024
@milankl milankl changed the title [working in progress]fix: a bug when using set! Number format flexibility with set! Dec 12, 2024
@milankl milankl linked an issue Dec 12, 2024 that may be closed by this pull request
Reanalysis data as initial conditions #630
Open
@milankl milankl merged commit 0578a7a into SpeedyWeather:main Dec 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milankl milankl milankl left review comments

Assignees
No one assigned
Labels
bug 🐞 Something isn't working initial conditions 🚥 Initial conditions of model simulations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reanalysis data as initial conditions
3 participants
@rocroc2017 @milankl @roc-climate