Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: created an helper class that creates a directory in home #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davidongora
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@javaspeak javaspeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a class called:

DirectoryHelperImpl and an interface called DirectoryHelper

You should not be asking the user for the repo name. All the DirectoryHelperImpl should be doing is creating a directory if it does not exist and deleting it and recreating it again if it does exist.

Remember the next task was going to be reading repo details from application.yml file. Therefore you do not need to get the location from the user.

@davidongora
Copy link
Collaborator Author

Okay i will work on it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants