Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does from_bot/user_token return a Result? #128

Open
jD91mZM2 opened this issue Jul 13, 2017 · 2 comments
Open

Why does from_bot/user_token return a Result? #128

jD91mZM2 opened this issue Jul 13, 2017 · 2 comments
Labels
question

Comments

@jD91mZM2
Copy link
Contributor

Why does from_bot/user_token return a Result?
I mean, it always returns Ok() either way...
@SpaceManiac
Copy link
Owner

Future-proofing, in the case that these methods should ever need to change to validate their tokens or any such similar thing.

@jD91mZM2
Copy link
Contributor Author

I don't think they should. Not validating is much faster, plus the websocket already returns an error on invalid token, PLUS you can already validate by querying the current user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SpaceManiac @jD91mZM2