Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release to crates.io #17

Closed
neysofu opened this issue Sep 7, 2023 · 7 comments · Fixed by #20
Closed

Release to crates.io #17

neysofu opened this issue Sep 7, 2023 · 7 comments · Fixed by #20
Assignees

Comments

@neysofu
Copy link
Member

neysofu commented Sep 7, 2023

We can't publish celestia to https://crates.io until all of its dependencies have been as well, and this includes nmt-rs.

@zvolin
Copy link
Contributor

zvolin commented Sep 7, 2023

Hey, sorry to interrupt. I guess when you mean celestia, it is about your celestia-adapter for sovereign-sdk.
Would you reconsider renaming it before to reflect the fact that it's an adapter? At @eigerco we're developing the celestia node and thus we hoped we could have celestia name for it's CLI, like the go version does

@neysofu
Copy link
Member Author

neysofu commented Sep 7, 2023

Hey @zvolin, no problem. I wasn't aware of the potential name conflict. Consider celestia yours, we'll switch to sov-celestia-adapter.

@zvolin
Copy link
Contributor

zvolin commented Sep 7, 2023

Thanks @neysofu!

@zvolin
Copy link
Contributor

zvolin commented Nov 6, 2023

hey, do you still plan to publish? we're considering publishing our crates and we also depend on nmt-rs

@zvolin
Copy link
Contributor

zvolin commented Nov 6, 2023

ah by the way our publish to crates.io is also a blocker for you to publish sov-celestia-adapter 🤔

@neysofu
Copy link
Member Author

neysofu commented Nov 12, 2023

Hey, we didn't have an immediate need for it so we just postponed the release. I'll make sure we get the release out within this week, I'll ping you here when it's ready!

You folks can then release celestia-node-rs crates and sov-celestia-adapter will also be unblocked. 🙂

@neysofu neysofu self-assigned this Nov 12, 2023
@neysofu neysofu linked a pull request Nov 14, 2023 that will close this issue
@neysofu
Copy link
Member Author

neysofu commented Nov 14, 2023

Here it is: https://crates.io/crates/nmt-rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants