Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRAPI v2 :: POST /brapi/v2/search/callsets doesn't filter by germplasmDbIds #47

Open
mcrimi opened this issue Apr 26, 2022 · 1 comment

Comments

@mcrimi
Copy link

mcrimi commented Apr 26, 2022

Steps to reproduce

URL: http://gigwa.bms-uat-test.net:8080/gigwa/rest/brapi/v2/search/studies
Database: Sorghum

Log-in with default admin credentials


POST http://gigwa.bms-uat-test.net:8080/gigwa/rest/brapi/v2/search/studies

{
  "germplasmDbIds": ["10_00984"],
  "variantSetDbIds": ["sorghum§1§1470.002"]
}

Expected result
Only the callSet of the individual are returned.

Actual result
All callSets of the variantSet are returned

@aliceboizet @GuilhemSempere

GuilhemSempere added a commit to GuilhemSempere/Mgdb2BrapiV2Impl that referenced this issue May 3, 2022
@GuilhemSempere
Copy link
Collaborator

Just to make things clear, we're talking about /search/callsets, not /search/studies
Yes for quite a few calls the initial implementation is pretty basic as we were essentially targeting FlapJack use-cases, that's why some parameters were not being supported. The recently committed implementation of /search/callsets (in https://github.com/SouthGreenPlatform/Mgdb2BrapiV2Impl) is now able to handle germplasmDbIds, be it or not combined with callSetDbIds and / or variantSetDbIds. You can try it out on South Green's staging instance: https://gigwa-dev.southgreen.fr/
Make sure you provide correct germplasmDbIds though (individual names must be prefixed with "db_name§project_number§")
This improvement will be included in the next release (v2.5.1) that we hope to make available before the summer when issues reported about v2.5 will have been treated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants