Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: direct_replier.py sample is broken #43

Open
TrentDaniel opened this issue Apr 30, 2024 · 0 comments
Open

[Bug]: direct_replier.py sample is broken #43

TrentDaniel opened this issue Apr 30, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@TrentDaniel
Copy link
Collaborator

Bug Description

  • Line 27 has a an improper comparison to None with request.get_payload_as_string() != None
  • Line 41 references a variable outbound_msg_builder when no variable under that name has been instantiated

Expected Behavior

  • Line 27, the comparison should be written as request.get_payload_as_string() is not None
  • Line 41, instead of referencing outbound_msg_builder, self.message_builder should be referenced

Steps to Reproduce

Reproduction not required, just look at source.

Solace Product

Solace APIs

Solace Broker version

sample issue, not relevant

Solace API

sample issue, not relevant

Solace API version

sample issue, not relevant

@TrentDaniel TrentDaniel added the bug Something isn't working label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant