Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solace Direct Messaging capability #76

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Solace Direct Messaging capability #76

merged 1 commit into from
Jul 19, 2024

Conversation

SravanThotakura05
Copy link
Collaborator

@SravanThotakura05 SravanThotakura05 commented Jul 12, 2024 •
edited
Loading

Solace Direct Messaging Capability.

  1. Enabled client.type property to check for client type direct or persistent
  2. Implemented seperate class for Direct messaging client
  3. Renamed few properties that are common to direct and persistent messaging client
  4. Added tests to validate direct messaging capability

@SravanThotakura05
Copy link
Collaborator Author

@ozangunalp Review comments are addressed in this commit - #76

@SravanThotakura05 SravanThotakura05 marked this pull request as ready for review July 17, 2024 10:42
@ozangunalp
Copy link
Collaborator

@SravanThotakura05 Looks good to me. Maybe we can squash the commits.

@SravanThotakura05
Solace Direct Messaging Capability
4484bac 
Removed Unused config

fix failing test

Fix failing tests

Review comments and Documentation update

Fixed failing test and updated documentation

Direct Messaging: Publish failed listener to track failures and update health status

Updated property names which are common to direct and persistent messaging

Solace Direct Messaging capability
@SravanThotakura05 SravanThotakura05 force-pushed the feature-direct-messaging branch from f557850 to 4484bac Compare July 18, 2024 16:00
@SravanThotakura05
Copy link
Collaborator Author

@ozangunalp removed unused config and squashed commits

@SravanThotakura05 SravanThotakura05 merged commit 0d20e0d into main Jul 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozangunalp ozangunalp ozangunalp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SravanThotakura05 @ozangunalp