Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Code Analysis #268

Open
Bugman-creator opened this issue Nov 21, 2020 · 1 comment
Open

Static Code Analysis #268

Bugman-creator opened this issue Nov 21, 2020 · 1 comment

Comments

@Bugman-creator
Copy link

This is for a class project. A Static Code Analysis Tool was run on your project and filtered to only include correct findings
Please find attached the file containing the errors. This file includes the error type, as well as the files and lines where the errors occur

simulaqronSCAResults.txt

@AckslD
Copy link
Member

AckslD commented Nov 23, 2020

Thanks for pointing this out! The issues pointed out is the use of eval. Two occurrences of this are very easy to fix by making use of ast.literal_eval. However, we also make use of this to evaluate the name of a class as a string to the actual class. Not sure directly how to do this in general without using eval. It should be stated that these calls to eval do not use strings coming from a user so should not be a problem as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants