-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/jsdoc4 update #242
base: master
Are you sure you want to change the base?
Chore/jsdoc4 update #242
Conversation
Added in fix for #174. Subcategory now works for globals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@njetsy everything looks good to me.
NAB: Some files formatting is odd. Eg. publish.js Line 372, react-wrapper.js Line 74.
@wojtek-krysiak Can anyone help us here? This PR would really be welcome by the community since it fixes so many issues. |
Yeah, this PR defs fixes issues I've been having with better-docs |
Another vote that this works. Installed this version with jsdoc 4.0.2 and the audit issues are resolved while my docs still work the same |
Any progress on this? |
@njetsy @par5ul1 @wmurphyrd @pacholoamit @absqueued Hi, I've just released this on new You can install this via The old |
Thank you so much for the update!! I'll give the new version a go. |
Thank you again for releasing this! Everything is working perfectly in my setup. As an FYI, I've only run into two issues when using the
In both cases I think parcel spits out an error during the bundling process. |
Some updates to improve compatibility with current versions of packages:
This probably needs some more work or another look over but it should be a good start. I did not do any vue testing, but it is working with the latest version of parcel 2, react 18, and jsdoc 4. Both category and component tags confirmed working with live previews and prop-type recognition.
(Thanks for the amazing head start with this BTW!)