Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWSOptions type information is not compatible by aws-sdk v3 #71

Open
kkoudev opened this issue Oct 17, 2023 · 0 comments
Open

AWSOptions type information is not compatible by aws-sdk v3 #71

kkoudev opened this issue Oct 17, 2023 · 0 comments

Comments

@kkoudev
Copy link

kkoudev commented Oct 17, 2023

The type information of AWSOptions has not changed since using aws-sdk v2.
Therefore, this type needs to be changed to aws-sdk v3 compatible type.

Specifically, the differences are as follows.

aws-sdk v2 compatible type (current type)

export type AWSOptions = {
  accessKeyId?: string;
  secretAccessKey?: string;
  region: string;
  bucket: string;
  expires?: number;
}

aws-sdk v3 compatible type

export type AWSOptions = {
  credentials?: {
    accessKeyId: string;
    secretAccessKey: string;
  },
  region: string;
  bucket: string;
  expires?: number;
}

In the current implementation, the AWSOptions information is passed as is to the S3 Client option information.
So If it do not change the implementation of AWSProvider, it will need to change the AWSOptions type information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant