[Bug]: Fabricator ignore special recipes deleting result item / persistent ingredients

[DevDyna]

Mod Title

XyCraft Machines

Minecraft Version

1.20.1

Severity

Odd Results

NeoForge Version

Forge 47.3.11

Describe the Suggestion

Fabricator can delete recipe ingredients that aren't consumed

Reproduction Steps

1. Configure the fabricator like [Screen 1] and set on High Signal
2. Add input ingredients and the item that cannot be consumed [Screen 2]
3. Change the fabricator mode on Always On and see that it have consumed the original book (it persist on any recipes inclused custom with same logic) [Screen 3]

Screenshots and Videos

[Screen 1]

[Screen 2]

[Screen 3]

Additional Context

No response

[Soaryn]

Mmm will need to check after the weekend, but how are the ingredients specified as "not consumed" in the recipe itself for thos recipe? If memory serves I handled that I jnow stack get remainders are fine, and I had thought I had the recipe remainders were fine too. Buckets for instance are handled via the stack I think, but this also handles other cases It hough of special recipes.

Regardless will double check what the code is doing after the weekend

[DevDyna]

but how are the ingredients specified as "not consumed" in the recipe itself for thos recipe?

I have tested with a few of other special recipes and only one dont want to work -> banner cloning

also apparently that recipes are completly broken on any other "crafter"

except that i have try with other mods

• mystical agriculture infusion stone custom recipe (work without problems)
• pedestal upgrade base recipe (work without problems)
• kubejs -> ( it dont work but probably caused from keepIngredient() dont work properly when used variables or dynamic values as parameters KubeJS-Mods/KubeJS#913 )

[Soaryn]

OH! I just read 1.20.1 that is the wild west of bugs I feel for Xy as that isnt updated anymore 😅 So this is likely a bug, but should no longer be an issue if it was

[Soaryn]

Do you have an example of a vanilla recipe that has this behaviour? I designed the fabricator to work with things like cookware from pam's, etc. but wanted to check if it is working correctly in 1.21. 1.20.1 is very much a unsupported version at this point with all of the gradle changes I have made 😅

[DevDyna]

Do you have an example of a vanilla recipe that has this behaviour?

book cloning was one of that but apparently every 1.20.1 bug persist on 1.21.1

[Forge 1.20.1]

[Neo 1.21.1]

Complete list of recipe broken on fabricator

recipe that persist without execute the recipe

• banner cloning

recipe that execute but ignore nbt result

• armor dye
• firework star & rocket
• shield decoration (banner + shield)
• tipped arrow
• suspicious stew
• decorated pots (using sherds on recipe pattern grid)
• trasmute items (like shulker box)

[Soaryn]

For the first one (banner) try making one of the slots "strict" by ctrl clicking it. If you don't HAVE a control key, you will need to rebind in settings first :P

Shulker boxes are doing what I'd expect really.

That being said, cloning books does present a problem. Part of this is me wanting the fabricator to put back the items such as empty buckets BACK into the source they found them in. This will involve a much longer fix, but a bandaid seems to work for the moment for the more simple recipes:

This will likely be 1.21.3+ but there is a possibility at the very least to be back ported to 1.21.1. Depends on time.

[Soaryn]

Ok, the long route wasn't as long as I expected. It SHOULD be more robust which will allow a little more control on the user side when dealing with external inventories. So a bucket will empty and place the empty bucket back in the original slot if it can (assuming there is no other stackable option present). This means using something like the buffer will be a little easier to guess where a remainder will wind up if used early.

This does however, require mods to make sure that they write their getRemainingItems for their custom recipes correctly. Will keep testing, but with a minimal testing and no JEI in dev, it will be low priority for now

[DevDyna]

For the first one (banner) try making one of the slots "strict" by ctrl clicking it. If you don't HAVE a control key, you will need to rebind in settings first :P

tested with "strict mode" and completly delete the banner empty like book cloning

Shulker boxes are doing what I'd expect really.

with same input dye work , but if added a different dye it try to color it ignoring that wasn't the same

tested a few about that and it keep on consume any dye inside coloring the same shulker until it was the same color of result

[Soaryn]

As weird as the shulker box one is, that is vanilla recipe being vanilla. It is one of the reasons I added the strict mode.

I'll check banners again, but it was working as the recipe indicated

[Soaryn]

Can you get me an example of the banner recipe you are trying?
Ah so like this one? This should be fixed with the changes I made... or seems to be if it is exactly like the book copying, but it will need to be set to strict since the output matches the input, this forces the craft

[DevDyna]

Ah so like this one?

yes

[Soaryn]

Marking as completed then as fixed in dev in 1.21.3 😊
Still working on other attributes in my porting, but depending on how MC's changes changed that file may not be back portable to 1.21.1. At the moment, it is leaning towards only forward movement.