Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Prop14] Harvest() fails on Qi strats when no fees set #76

Open
timbotro opened this issue Oct 12, 2021 · 0 comments
Open

[Prop14] Harvest() fails on Qi strats when no fees set #76

timbotro opened this issue Oct 12, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@timbotro
Copy link

Looks like with the new prop14 changes we get errors when setKeep is set to 0

Steps to recreate:

  1. Deploy and configure new a new Qi strat, e.g. benqi-dai
  2. Call setKeep(0)
  3. Call harvest
    => Error: VM Exception while processing transaction: reverted with reason string 'PangolinLibrary: INSUFFICIENT_INPUT_AMOUNT' is thrown by contract, Setting keep to greater than 0 does not throw error, as you'd expect.

image
@timbotro timbotro added the bug Something isn't working label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timbotro