Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]Set the "Setup Shizuku" button opens Shizuku directly! #35

Open
2 tasks done
Itsfitts opened this issue Nov 4, 2024 · 1 comment
Open
2 tasks done
Labels
feature request Requesting a feature

Comments

@Itsfitts
Copy link

Itsfitts commented Nov 4, 2024

Describe the feature you would like to be added to WADBS. Make sure that the description is clear and detailed enough for a reader (developer or a new contributor) to understand.

  • This feature was not requested before (both as a feature request and as a bug report that such feature would fix)
  • I agree to keep the discussion polite and on topic

Set the button that appears when Shizuku is not actively running "Setup Shizuku" to then open the Shizuku app directly for quicker/easier activation.
This button currently opens a web link to the Shizuku user guide..

@Itsfitts Itsfitts added the feature request Requesting a feature label Nov 4, 2024
@Smooth-E
Copy link
Owner

Smooth-E commented Nov 4, 2024

Hello! Thank you for showing interest in WADBS. This sounds like a good addition, however, I think it is better to guide users to the website rather than to the app if Shizuku is not running (even if it is installed).

Currently, this is how it works:

shizukuButton.isEnabled = true
if (ShizukuUtilities.isShizukuAvailable()) {
    shizukuButton.text = getString(R.string.label_grant_permission)
    shizukuButton.setOnClickListener(requestShizukuPermission)
}
else {
    shizukuButton.text = getString(R.string.label_setup_shizuku)
    shizukuButton.setOnClickListener(proceedToShizukuWebsite)
}
fun isShizukuAvailable(): Boolean =
    Shizuku.pingBinder() && (Shizuku.getVersion() >= 11 && !Shizuku.isPreV11())

As you can see, we check whether Shizuku is available as well as its version. Shizuku API 11+ is needed for WADBS as it uses the UserService feature. Though I can check for whether the Shizuku manager package is installed, this may lead to a couple of confusions:

  • User has installed some fork of Shizuku manager with a different package name
  • User has an older version of Shizuku installed (Shizuku versioning is complicated, checking version codes may be not reliable)
  • Not technically inclined user installs WADBS and the Shizuku app from Google Play, then gets thrown into the Shizuku manager instead of being led to the documentation page
  • Though the Shiuzuku manager app has setup steps described inside of itself, it advises to read the documentation page anyway

Below in the "Start via wireless ADB block" it says "Please, read the step-by-step guide first" (WADBS does not work with this method) and in "Connect with your computer it says "Read help first". So it is a better idea to point to the website in my opinion.

Shizuku screenshot


What are your thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requesting a feature
Projects
None yet
Development

No branches or pull requests

2 participants