Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Implement AsFd for Connection and EventQueue #656

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Sep 8, 2023

This helps for using an Generic<EventQueue> with calloop 0.11.

#635 added this server-side for use in Smithay; the same thing seems useful for sctk.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.24% ⚠️

Comparison is base (cf825be) 73.26% compared to head (b2c9e76) 73.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
- Coverage   73.26%   73.03%   -0.24%     
==========================================
  Files          47       47              
  Lines        7755     7780      +25     
==========================================
  Hits         5682     5682              
- Misses       2073     2098      +25     
Flag Coverage Δ
main 58.31% <0.00%> (-0.19%) ⬇️
test-- 78.08% <0.00%> (-0.23%) ⬇️
test--server_system 61.35% <0.00%> (-0.14%) ⬇️
test-client_system- 69.11% <0.00%> (-0.29%) ⬇️
test-client_system-server_system 51.42% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
wayland-backend/src/client_api.rs 86.36% <0.00%> (-4.12%) ⬇️
wayland-backend/src/rs/client_impl/mod.rs 78.06% <0.00%> (-0.89%) ⬇️
wayland-backend/src/sys/client_impl/mod.rs 71.32% <0.00%> (-1.01%) ⬇️
wayland-client/src/conn.rs 83.87% <0.00%> (-2.08%) ⬇️
wayland-client/src/event_queue.rs 58.14% <0.00%> (-0.78%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@elinorbgr elinorbgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nitpicks on the changelogs. 👍

wayland-backend/CHANGELOG.md Show resolved Hide resolved
wayland-client/CHANGELOG.md Show resolved Hide resolved
@elinorbgr
Copy link
Member

If you rebase on master, the CI issues should go away. :)

This helps for using an `Generic<EventQueue>` with calloop 0.11.
@elinorbgr
Copy link
Member

Thanks!

@elinorbgr elinorbgr merged commit f7b0d58 into Smithay:master Sep 19, 2023
13 of 15 checks passed
@ids1024 ids1024 deleted the client-as-fd branch September 19, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants