Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.19] Typo Collection Thread #5201

Open
KnightMiner opened this issue Apr 3, 2024 · 20 comments
Open

[1.19] Typo Collection Thread #5201

KnightMiner opened this issue Apr 3, 2024 · 20 comments
Labels
1.19 Issue affects 1.19 Bug Issue describes unintended or broken behavior Translation Pull request or issues related to improving translations or the English text in game

Comments

@KnightMiner
Copy link
Member

KnightMiner commented Apr 3, 2024

This issue serves as a place to report minor typos or other issues with the English translation of the mod for 1.19. To report a typo, please reply to this issue using the following template:

* Tinkers' Construct Version: 
* Actual Text:
* Expected Text:
* Screenshot (if applicable):

Do not simply write "1.19.2" for version, give the full mod version number as shown on the forge mod list. Also keep typos to those visible in the 1.19.2 version of the mod, no typos for 1.18.2 (use #4932 for that) or for future versions (1.20 will be its own issue once released). Make sure you are on the latest version, its not useful for us to receive reports on an old version.

I will hide comments once they are fixed. I will also remove comments that are off topic and unnecessary discussion to keep this issue useful.

@KnightMiner KnightMiner added Bug Issue describes unintended or broken behavior Translation Pull request or issues related to improving translations or the English text in game 1.19 Issue affects 1.19 labels Apr 3, 2024
@KnightMiner KnightMiner pinned this issue Apr 3, 2024
@Gitcrafter

This comment was marked as resolved.

@Sun-Tears

This comment was marked as resolved.

@KnightMiner

This comment was marked as resolved.

@Mrthomas20121

This comment was marked as resolved.

@KodYazanDruid

This comment was marked as resolved.

@NyanMC

This comment was marked as resolved.

@Thebomb2d

This comment was marked as resolved.

@NyanMC

This comment was marked as resolved.

@TheMCSpacePro

This comment was marked as resolved.

@Zen9890

This comment was marked as resolved.

@Zen9890

This comment was marked as off-topic.

@Zen9890

This comment was marked as resolved.

@NyanMC

This comment was marked as resolved.

@NyanMC

This comment was marked as resolved.

@KnightMiner

This comment was marked as off-topic.

KnightMiner added a commit that referenced this issue Sep 16, 2024
Also fixes the wrong translation key being used for the enchantment conversion titles
@Cactusstudent

This comment was marked as resolved.

@KnightMiner
Copy link
Member Author

image

From discord, this should really be "infusing an object with your soul"

KnightMiner added a commit that referenced this issue Sep 20, 2024
(cherry picked from commit 9df2d76)
KnightMiner added a commit that referenced this issue Sep 20, 2024
Also fixes the wrong translation key being used for the enchantment conversion titles

(cherry picked from commit 4356f5c)
@Halt-alt
Copy link

Tinker's construct versiont: https://github.com/SlimeKnights/TinkersConstruct/blob/87bd22c24fe4cc7e57c28396e2c47537091615cb/src/main/java/slimeknights/tconstruct/tools/data/sprite/TinkerPartSpriteProvider.java#L30C1-L30C3
Actual text: addAllSpites
Expected text: addAllSprites
Changing this will also require addons that override the method (like materialis) to change the typo on their end.

@imsi32
Copy link
Contributor

imsi32 commented Nov 21, 2024

  • Tinkers' Construct Version: 3.8.4.50
  • Actual Text: Once you are comfortable with the basics, some of my colleagues have written their own books covering more advanced topics.
  • Expected Text: Once you are comfortable with the basics, you can read books that some of my colleagues have written covering more advanced topics.
  • Screenshot (if applicable):
    materials-and-you-further-reading

@imsi32
Copy link
Contributor

imsi32 commented Nov 21, 2024

  • Tinkers' Construct Version: 3.8.4.50
  • Actual Text: tool_stat.tconsturct.projectile_damage.description
  • Expected Text: tool_stat.tconstruct.projectile_damage.description
  • Screenshot (if applicable):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.19 Issue affects 1.19 Bug Issue describes unintended or broken behavior Translation Pull request or issues related to improving translations or the English text in game
Projects
None yet
Development

No branches or pull requests