Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crossbows should grant "Ol' Betsy" advancement #5200

Open
CyberWorldCatgirl opened this issue Mar 28, 2024 · 1 comment
Open

Crossbows should grant "Ol' Betsy" advancement #5200

CyberWorldCatgirl opened this issue Mar 28, 2024 · 1 comment
Labels
1.18 Issue affects 1.18 1.19 Issue affects 1.19 Confirmed Issue has been verified as being caused by Tinkers, or an enhancement is planned to be added Enhancement Issue or pull request addresses a change to an existing functional feature Forge Issue is caused by Forge or a Forge issue describes this issue. Resolution is often delayed. Minecraft Issue is actually a bug in the vanilla game, that Tinkers either exhibits or highlights Minor Issue does not have a large impact compared to the amount of work to fix it

Comments

@CyberWorldCatgirl
Copy link

Minecraft Version

1.18.2

Forge Version

40.2.17

Mantle Version

1.9.50

Tinkers' Construct Version

3.7.1.155

Problem description

You cannot get "Ol' Betsy" with a Tinkers' Crossbow. This advancement is obtained by firing a crossbow.

Suggested solution

Grant "Ol' Betsy" by firing any Tinkers' Crossbow.

Alternatives considered

If it proves impossible to get "Ol' Betsy" to work with Tinkers' Crossbows, perhaps include a disclaimer about that in Materials and You?

Additional context

Other advancements that are crossbow-related (including "Who's the Pillager Now?" and piercing-based crossbow advacements) function as expected. With current behavior, it is possible to get every Crossbow advancement except the advancement that suggests you fire a crossbow because of Tinkers' Crossbows.

Searched for existing enhancement?

Used the search bar, Checked the FAQ, Checked the in game books

@CyberWorldCatgirl CyberWorldCatgirl added 1.18 Issue affects 1.18 Enhancement Issue or pull request addresses a change to an existing functional feature Unreviewed Issue is new and is awaiting the team to review it labels Mar 28, 2024
@KnightMiner KnightMiner added Forge Issue is caused by Forge or a Forge issue describes this issue. Resolution is often delayed. Minecraft Issue is actually a bug in the vanilla game, that Tinkers either exhibits or highlights Confirmed Issue has been verified as being caused by Tinkers, or an enhancement is planned to be added and removed Unreviewed Issue is new and is awaiting the team to review it labels Apr 1, 2024
@KnightMiner
Copy link
Member

Looked into this issue, crossbows use a special criteria trigger, but the advancement is not just checking against that trigger, its checking against that trigger with the vanilla item. Really Forge should make that support tags, but as a workaround I can just force grant the enchantment. That said, since it takes a bit of effort going to consider this lower priority.

@KnightMiner KnightMiner added the Minor Issue does not have a large impact compared to the amount of work to fix it label Apr 1, 2024
@KnightMiner KnightMiner added the 1.19 Issue affects 1.19 label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.18 Issue affects 1.18 1.19 Issue affects 1.19 Confirmed Issue has been verified as being caused by Tinkers, or an enhancement is planned to be added Enhancement Issue or pull request addresses a change to an existing functional feature Forge Issue is caused by Forge or a Forge issue describes this issue. Resolution is often delayed. Minecraft Issue is actually a bug in the vanilla game, that Tinkers either exhibits or highlights Minor Issue does not have a large impact compared to the amount of work to fix it
Projects
None yet
Development

No branches or pull requests

2 participants