Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using volume clip for creating labels #93

Open
che85 opened this issue Nov 20, 2015 · 7 comments
Open

Using volume clip for creating labels #93

che85 opened this issue Nov 20, 2015 · 7 comments

Comments

@che85
Copy link
Member

che85 commented Nov 20, 2015

Using volume clip would improve timing for creating labels

@fedorov
Copy link
Member

fedorov commented Nov 20, 2015

Using volume clip would improve timing for creating labels

Important detail is that VolumeClip will not work when points are in-plane (which is common for prostate MRI annotation). It will be important to either warn the user about this, or have an alternative mechanism to create an in-plane label when all points are in one plane (this would probably make sense to add to VolumeClip directly).

@lassoan
Copy link
Contributor

lassoan commented Apr 21, 2017

We have a greatly improved version of the markups to model algorithm, which takes care of having all the points being in the same plane and other things. It is implemented in the markups to model module in SlicerIGT extension. I don't know if making SlicerProstate depend on SlicerIGT would be acceptable or we should move the Markups to model module in the Slicer core or find some other solution.

@che85
Copy link
Member Author

che85 commented Apr 21, 2017

@lassoan Since we are anyway planning to integrate the SegmentEditor in mpReview, we will have to wait until the VolumeClip effect is ready.

For SliceTracker I implemented a module called VolumeClipToLabel:

https://github.com/SlicerProstate/SliceTracker/blob/master/SliceTracker/VolumeClipToLabel.py

@che85
Copy link
Member Author

che85 commented Apr 21, 2017

image

@fedorov
Copy link
Member

fedorov commented Apr 21, 2017

@lassoan can you clarify - does it still make sense to integrate VolumeClip as a SegmentEditor effect, or it is superseded by the functionality you discussed available in SlicerIGT?

@lassoan
Copy link
Contributor

lassoan commented Apr 21, 2017

SlicerIGT contains robust point to surface generation algorithm (and GUI for applying it for model node generation from markup node). It may make sense to make it available in the Slicer core as such functionality is quite often needed. If the algorithm is in the Slicer core then all acripted modules, segment editor effects, etc. could use it.

@lassoan
Copy link
Contributor

lassoan commented Apr 21, 2017

Making the algorithm available as a Segment editor effect would be still useful (users would not need to go through several modules to define a segment with points).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants