ENH: Add new dependencies to SlicerMorph.json #2101
Conversation
Adds Sandbox and SurfaceMarkup as dependencies to the SlicerMorph extension.
| @@ -1,6 +1,10 @@ | |||
| { | |||
| "$schema": "https://raw.githubusercontent.com/Slicer/Slicer/main/Schemas/slicer-extension-catalog-entry-schema-v1.0.0.json#", | |||
| "build_dependencies": ["SegmentEditorExtraEffects"], | |||
| "build_dependencies": [ | |||
There was a problem hiding this comment.
https://slicer.readthedocs.io/en/latest/developer_guide/extensions.html#extension-catalog-entry-file
These don’t appear to be build dependencies but rather runtime dependencies? SurfaceMarkup is already specified to be installed when running the PlaceLandmarkGrid module:
https://github.com/SlicerMorph/SlicerMorph/blob/40407085db40774fd976a0bac4c6c287f49b5576/PlaceLandmarkGrid/PlaceLandmarkGrid.py#L48-L64
There was a problem hiding this comment.
Reviewing the Slicer ExtensionsIndex pull request template it appears this change would put it inconsistent with the extension’s listed dependencies in its top level CMakeLists.txt.
There was a problem hiding this comment.
Thanks @jamesobutler, these are runtime dependencies and I agree it would be better to install at runtime.
Adds Sandbox and SurfaceMarkup as dependencies to the SlicerMorph extension.