Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow turbolift to toggle or set draft status for PRs #12

Open
rnorth opened this issue Apr 8, 2021 · 3 comments
Open

Allow turbolift to toggle or set draft status for PRs #12

rnorth opened this issue Apr 8, 2021 · 3 comments
Labels
feature good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rnorth
Copy link
Collaborator

rnorth commented Apr 8, 2021

Would help with usability of #11

@rnorth rnorth added feature good first issue Good for newcomers help wanted Extra attention is needed labels Apr 8, 2021
@sledigabel
Copy link
Contributor

Was partially addressed with this: #61
There doesn't seem to be an official way through the gh client to revert a "ready" PR to a draft.
cli/cli#2271

We would have to make use of the API, or use that approach:
https://github.com/kyanny/gh-pr-draft/blob/main/gh-pr-draft

@Dan7-7-7
Copy link
Collaborator

Is this still an issue after cli/cli#5995? Since we now presumably have turbolift foreach gh pr ready --undo
There might still be the problem of setting the default remote repository before this command will work. But I'm not sure whether that's an issue to be dealt with here.

@sledigabel
Copy link
Contributor

Nice one, thanks for raising this @Dan7-7-7 ! Wasn't aware of cli/cli#5995, this is great news.

I'd be happy to close this PR, we could maybe discuss the possible shortcut of using turbolift update-prs with extra flags for this. I'll leave it open until our next turbolift review board.

cc @rnorth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants