-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waypoints refactor #976
Open
kevinthegreat1
wants to merge
18
commits into
SkyblockerMod:master
Choose a base branch
from
kevinthegreat1:waypoints-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Waypoints refactor #976
kevinthegreat1
wants to merge
18
commits into
SkyblockerMod:master
from
kevinthegreat1:waypoints-refactor
+1,204
−856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viciscat
previously approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good I suppose but did not test, might do that at some point.
LifeIsAParadox
added
merge me please
Pull requests that are ready to merge
and removed
reviews needed
This PR needs reviews
labels
Sep 17, 2024
I’ll wait for aaron to look at this pr. |
kevinthegreat1
added
reviews needed
This PR needs reviews
and removed
merge me please
Pull requests that are ready to merge
labels
Sep 20, 2024
AzureAaron
requested changes
Sep 21, 2024
src/main/java/de/hysky/skyblocker/skyblock/waypoint/OrderedWaypoints.java
Show resolved
Hide resolved
src/main/java/de/hysky/skyblocker/skyblock/waypoint/OrderedWaypoints.java
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
This PR need changes
and removed
reviews needed
This PR needs reviews
labels
Sep 21, 2024
LifeIsAParadox
added
reviews needed
This PR needs reviews
and removed
changes requested
This PR need changes
labels
Sep 21, 2024
kevinthegreat1
force-pushed
the
waypoints-refactor
branch
from
October 8, 2024 06:17
00c33a8
to
3270096
Compare
Closes #1024. |
LifeIsAParadox
added
merge conflicts
This PR has merge conflicts that need solving.
and removed
reviews needed
This PR needs reviews
labels
Nov 16, 2024
kevinthegreat1
force-pushed
the
waypoints-refactor
branch
from
November 22, 2024 21:40
fb6d881
to
435b7d8
Compare
LifeIsAParadox
added
reviews needed
This PR needs reviews
and removed
merge conflicts
This PR has merge conflicts that need solving.
labels
Nov 22, 2024
AzureAaron
requested changes
Nov 23, 2024
LifeIsAParadox
added
changes requested
This PR need changes
reviews needed
This PR needs reviews
and removed
reviews needed
This PR needs reviews
changes requested
This PR need changes
labels
Nov 23, 2024
kevinthegreat1
force-pushed
the
waypoints-refactor
branch
from
November 24, 2024 02:40
c48ccef
to
d276f87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights
Ordered waypoints have been migrated to waypoints gui.
New Skyblocker Waypoints format
API Design
The "wither" pattern is employed. Each class extending
Waypoint
should override all "wither" methods to return a new instance of the subclass to ensure the runtime type of the waypoint is correct.API Changes
I have tried to keep API changes to a minimum, but here are the breaking changes:
Waypoint#setShouldRender
has been renamed toWaypoint#setEnabled
.Waypoint#getColorComponents
has been renamed toWaypoint#getRenderColorComponents
.Waypoint#render
now checksWaypoint#shouldRender
.shouldRender
to false andshouldRenderName
to true.NamedWaypoint#shouldRenderName
now defaults toWaypoint#shouldRender
.shouldRenderName
to always render the name.Bug Fixes