Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated stats #1696

Closed
wants to merge 50 commits into from
Closed

Updated stats #1696

wants to merge 50 commits into from

Conversation

DuckySoLucky
Copy link
Member

@DuckySoLucky DuckySoLucky commented Oct 1, 2022 •
edited
Loading

Description

Better version of #1639
Adds new stats
Shows more accurate stats (Tested on 2 endgame profiles, accuracy is like 90-95%, mostly because of cookie and missing stuff in the API)

Closes #1393
Closes #1951

Examples

image
image

Items like slayer armor (Every X kills gain x defense) do not get applied unless u are in combat with that type of mob

@DuckySoLucky
Copy link
Member Author

Should not be merged before #1648 and #1651

dukio
dukio suggested changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@dukio dukio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't read through everything right now but I saw a couple things (see comments below).

Also this will need to get an upstream once bestiary PR gets merged, cuz right now it has bestiary things too

public/resources/ts/calculate-player-stats.ts Outdated Show resolved Hide resolved
common/constants/bonuses.js Outdated Show resolved Hide resolved
@MartinNemi03 MartinNemi03 mentioned this pull request Dec 30, 2022
Merged
MartinNemi03
MartinNemi03 requested changes Jan 16, 2023
View reviewed changes
Copy link
Member

@MartinNemi03 MartinNemi03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on 56 profiles and found the following:

  • stats don't load on: Ephemera, Refraction, Technoblade
  • selected_power breaks jjww2's profile

@DuckySoLucky
Copy link
Member Author

tested on 56 profiles and found the following:

  • stats don't load on: Ephemera, Refraction, Technoblade
  • selected_power breaks jjww2's profile

Fixed

@DuckySoLucky DuckySoLucky requested review from MartinNemi03 and removed request for dukio January 29, 2023 10:12
@Zickles Zickles mentioned this pull request May 29, 2023
Closed
@github-actions github-actions bot added the has conflicts when a PR has conflicts label Jun 26, 2023
@DuckySoLucky DuckySoLucky mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dukio dukio dukio requested changes

@MartinNemi03 MartinNemi03 Awaiting requested review from MartinNemi03

Assignees
No one assigned
Labels
has conflicts when a PR has conflicts size/XXL
Projects
Status of Pull Requests
Status: Drafts/Waiting
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stats bug Enhance stats
3 participants
@DuckySoLucky @dukio @MartinNemi03