Refactor ExprFilter to use new parser data API #6342
Closed
+212
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pikachu920
added
the
enhancement
|
wasn't there something like ExprInput? that handled the inputs? |
it's now a separate class, ExprFilterInput |
|
ohhhh I didn't realize it wasn't already |
TheLimeGlass
requested changes
Jan 18, 2024
TheLimeGlass
requested changes
Feb 1, 2024
APickledWalrus
requested changes
Mar 9, 2024
| Set<ExprFilterInput<?>> dependentInputs = parentFilter.getDependentInputs(); | ||
| dependentInputs.remove(this.source); | ||
| dependentInputs.add(this); | ||
|
|
|
|
||
| } | ||
| this.types = types; | ||
| this.superType = (Class<T>) Utils.getSuperType(types); |
There was a problem hiding this comment.
I wonder if we want to ensure that the return type is one Skript is aware of. That is, ensure a ClassInfo exists for it.
|
Closing as #6737 has implemented this functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactors ExprFilter to use new parser data API instead of the static based method it was using before
Target Minecraft Versions: any
Requirements: none
Related Issues: none