-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make EffBroadcast calls BroadcastMessageEvent #5979
Merged
sovdeeth
merged 13 commits into
SkriptLang:dev/feature
from
NotSoDelayed:enhance/effbroadcast-call-event
Jul 1, 2024
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b147d18
Support BroadcastMessageEvent
NotSoDelayed 63355a5
Clean up
NotSoDelayed a422289
Clean up
NotSoDelayed c06c976
Merge branch 'dev/feature' into enhance/effbroadcast-call-event
sovdeeth 8678fc9
Recipient set unmodifiable
NotSoDelayed d486ee4
Merge branch 'dev/feature' into enhance/effbroadcast-call-event
Moderocky 88dee31
Use deprecated constructor for 1.13 users
NotSoDelayed 8e1247a
Merge branch 'dev/feature' into enhance/effbroadcast-call-event
Moderocky 9442eb4
Move version tag to javadocs
NotSoDelayed b3b7720
Merge branch 'dev/feature' into enhance/effbroadcast-call-event
Moderocky 14b5c84
Merge branch 'dev/feature' into enhance/effbroadcast-call-event
Moderocky 3be1a79
Fix version check for legacy constructor call
NotSoDelayed 7c0e02b
Merge branch 'dev/feature' into enhance/effbroadcast-call-event
sovdeeth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be worth while making a public static final for this in
Utils
? we currently have this created in utils, raw string and now effect broadcast.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to honestly, but I'm afraid that such changes seems out of scope of this PR for the team. So I'll leave this as is.