Add filter support to ExprItemsIn #4614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TPGamesNL
added
the
enhancement
APickledWalrus
requested changes
Mar 5, 2022
|
have a sec to review pls? @APickledWalrus |
TPGamesNL
reviewed
Apr 6, 2022
AyhamAl-Ali
requested changes
Jul 30, 2022
Pikachu920
requested review from
TPGamesNL,
APickledWalrus,
AyhamAl-Ali and
TheLimeGlass
and removed request for
TheLimeGlass
AyhamAl-Ali
approved these changes
Oct 12, 2022
TPGamesNL
reviewed
Oct 12, 2022
|
Addressed reviews, but this is now pending #5077 as the test is failing due to an NPE in |
APickledWalrus
requested changes
Nov 24, 2022
TheLimeGlass
previously requested changes
May 3, 2023
|
ExprXOf.sk is failing when it shouldn't be. Changes made in this pull request have affected that test. |
Moderocky
force-pushed
the
master
branch
2 times, most recently
from
bd134d0 to
3f08853
Compare
Pikachu920
force-pushed
the
feature/filteritemsin
branch
from
f8ac120 to
7134ccb
Compare
Moderocky
approved these changes
Dec 21, 2023
APickledWalrus
requested changes
Dec 21, 2023
APickledWalrus
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds supports to get only certain item types when using ExprItemIn (e.g.
all swords in player's inventory).Target Minecraft Versions: All
Requirements: None
Related Issues: #4612